Skip to content

Make Handle component propagate onBlur, onMouseDown and onKeyDown events#605

Open
jonpacker wants to merge 1 commit into
react-component:masterfrom
jonpacker:master
Open

Make Handle component propagate onBlur, onMouseDown and onKeyDown events#605
jonpacker wants to merge 1 commit into
react-component:masterfrom
jonpacker:master

Conversation

@jonpacker

Copy link
Copy Markdown

Currently if passing these event handler to a Handle component in a custom handle, they will be swallowed by Handle's internal event handlers. This PR simply propagates the events to the passed event handler if they exist.

@jonpacker

Copy link
Copy Markdown
Author

Not sure what the best way to resolve the linter error is here. It's misleading to put these props on the propTypes because the component itself doesn't do anything with them.

@afc163

afc163 commented Dec 6, 2019

Copy link
Copy Markdown
Member

ci broken, please check it.

@yoyo837

yoyo837 commented Apr 15, 2023

Copy link
Copy Markdown
Member

Rebase please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants