diff --git a/.ci/bootstrap_catdog.sh b/.ci/bootstrap_catdog.sh index b87d1260..b0670833 100755 --- a/.ci/bootstrap_catdog.sh +++ b/.ci/bootstrap_catdog.sh @@ -24,7 +24,7 @@ cd ../pulp_catdog # ignore unused imports ruff check .ci || exit 1 # check ci files before ignoring imports -echo $'[tool.ruff.lint]\nignore = [ "F401" ]' >> pyproject.toml +sed -i -e '/\[tool.ruff.lint\]/a ignore = ["F401"]' pyproject.toml # include post_before_script to generate migrations cp ../plugin_template/.ci/post_before_script.sh .github/workflows/scripts diff --git a/.ci/scripts/pr_labels.py b/.ci/scripts/pr_labels.py index 0c478a21..4f801c39 100755 --- a/.ci/scripts/pr_labels.py +++ b/.ci/scripts/pr_labels.py @@ -4,9 +4,9 @@ import re import sys -import tomllib from pathlib import Path +import tomllib from git import Repo diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 0a9eb53d..7c8b72e1 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -56,10 +56,6 @@ jobs: run: | ruff check - - name: "Check for common gettext problems" - run: | - sh .ci/scripts/check_gettext.sh - - name: "Run extra lint checks" run: | [ ! -x .ci/scripts/extra_linting.sh ] || .ci/scripts/extra_linting.sh diff --git a/README.md b/README.md index be2f1944..0751a088 100644 --- a/README.md +++ b/README.md @@ -39,8 +39,6 @@ The following settings are stored in `template_config.yml`. check_commit_message Include inspection of commit message for a reference to an issue in pulp.plan.io. - check_gettext Check for problems with gettext such as mixing f-strings with gettext. - check_manifest Runs check-manifest to see if any files that were unintentionally left out of MANIFEST.in. For more info, see https://pypi.org/project/check-manifest/. diff --git a/plugin-template b/plugin-template index 902d78b0..3dc4b09d 100755 --- a/plugin-template +++ b/plugin-template @@ -13,13 +13,13 @@ # ] # /// -import typing as t import argparse import os import shlex import shutil import subprocess import sys +import typing as t from pathlib import Path import jamldump @@ -30,7 +30,6 @@ import utils DEFAULT_SETTINGS = { "check_commit_message": True, - "check_gettext": True, "check_manifest": True, "check_stray_pulpcore_imports": True, "cli_package": "pulp-cli", @@ -153,6 +152,7 @@ DEPRECATED_FILES = { ".ci/assets/bindings/.gitkeep", ".ci/scripts/changelog.py", ".ci/scripts/calc_deps_lowerbounds.py", + ".ci/scripts/check_gettext.sh", ".ci/scripts/cherrypick.sh", ".ci/scripts/docs-builder.py", ".ci/scripts/publish_docs.sh", diff --git a/pyproject.toml b/pyproject.toml index 3d3c29ef..cd077647 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -9,3 +9,6 @@ issue_format = "`#{issue}