Skip to content

Commit f234f0d

Browse files
authored
crypto: fix warnings in test_node_crypto.cc
Fix build warnings by casting the number literals to the size_t constants they are compared against. Signed-off-by: Maya Lekova <maya@igalia.com> PR-URL: #63490 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
1 parent 330f44f commit f234f0d

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

test/cctest/test_node_crypto.cc

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,23 +28,23 @@ TEST(NodeCrypto, NewRootCertStore) {
2828
*/
2929
TEST(NodeCrypto, MemoryTrackingConstants) {
3030
// Verify that our memory tracking constants are defined and reasonable
31-
EXPECT_GT(node::crypto::kSizeOf_SSL_CTX, 0)
31+
EXPECT_GT(node::crypto::kSizeOf_SSL_CTX, static_cast<size_t>(0))
3232
<< "SSL_CTX size constant should be positive";
33-
EXPECT_GT(node::crypto::kSizeOf_X509, 0)
33+
EXPECT_GT(node::crypto::kSizeOf_X509, static_cast<size_t>(0))
3434
<< "X509 size constant should be positive";
35-
EXPECT_GT(node::crypto::kSizeOf_EVP_MD_CTX, 0)
35+
EXPECT_GT(node::crypto::kSizeOf_EVP_MD_CTX, static_cast<size_t>(0))
3636
<< "EVP_MD_CTX size constant should be positive";
3737

3838
// Verify reasonable size ranges (basic sanity check)
39-
EXPECT_LT(node::crypto::kSizeOf_SSL_CTX, 10000)
39+
EXPECT_LT(node::crypto::kSizeOf_SSL_CTX, static_cast<size_t>(10000))
4040
<< "SSL_CTX size should be reasonable";
41-
EXPECT_LT(node::crypto::kSizeOf_X509, 10000)
41+
EXPECT_LT(node::crypto::kSizeOf_X509, static_cast<size_t>(10000))
4242
<< "X509 size should be reasonable";
43-
EXPECT_LT(node::crypto::kSizeOf_EVP_MD_CTX, 1000)
43+
EXPECT_LT(node::crypto::kSizeOf_EVP_MD_CTX, static_cast<size_t>(1000))
4444
<< "EVP_MD_CTX size should be reasonable";
4545

4646
// Specific values we expect based on our implementation
47-
EXPECT_EQ(node::crypto::kSizeOf_SSL_CTX, 240);
48-
EXPECT_EQ(node::crypto::kSizeOf_X509, 128);
49-
EXPECT_EQ(node::crypto::kSizeOf_EVP_MD_CTX, 48);
47+
EXPECT_EQ(node::crypto::kSizeOf_SSL_CTX, static_cast<size_t>(240));
48+
EXPECT_EQ(node::crypto::kSizeOf_X509, static_cast<size_t>(128));
49+
EXPECT_EQ(node::crypto::kSizeOf_EVP_MD_CTX, static_cast<size_t>(48));
5050
}

0 commit comments

Comments
 (0)