Skip to content

v0.6.2 tag contains Cargo.toml with version 0.6.1 — binary self-reports wrong version #614

@SuhasSrinivasan

Description

@SuhasSrinivasan

Issue:
When building modkit from the v0.6.2 git tag, the compiled binary reports modkit 0.6.1.

Steps to reproduce:

git clone https://github.com/nanoporetech/modkit.git
cd modkit
git checkout v0.6.2
git show v0.6.2:modkit/Cargo.toml | grep '^version'
# → version = "0.6.1"
git show v0.6.2:modkit-core/Cargo.toml | grep '^version'
# → version = "0.6.1"
cargo build --release --features accelerate,tch
./target/release/modkit --version
# → modkit 0.6.1

Expected:
modkit 0.6.2

Actual:
modkit 0.6.1

Cause:
The v0.6.2 tag points to commit a65409a (merge of PR #593), but the version bump in Cargo.toml for both modkit and modkit-core was not included in that commit or any commit reachable from the tag.

Suggested fix:
Either re-tag v0.6.2 to include the version bump, or create a v0.6.3 patch release with the corrected version strings.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions