protector mod calls deprecated `factions.get_player_faction`

[dennisjenkins75]

The protector mod calls deprecated factions.get_player_faction (returns one faction name). This is logged to the server logs repeatedly. The replacement, factions.get_player_factions, returns all factions (players can be members of more than 1).

[wsor4035]

relevant section https://github.com/mt-mods/playerfactions/blob/77fe095ac839908b71ea0d9b1a58a3a6c171c465/init.lua#L60-L72. additionally the readme should probably to updated to denote its depreciated status

[wsor4035]

current:

protector/init.lua

Lines 60 to 80 in 3a3b225

	-- check for member name
	local is_member = function (meta, name)
	if factions_available
	and meta:get_int("faction_members") == 1
	and factions.get_player_faction(name) ~= nil
	and factions.get_player_faction(meta:get_string("owner")) ==
	factions.get_player_faction(name) then
	return true
	end
	for _, n in pairs(get_member_list(meta)) do
	if n == name then
	return true
	end
	end
	return false
	end

not tested but should work

local is_member = function (meta, name)

	if factions_available and meta:get_int("faction_members") == 1 then
        local p_factions = factions.get_player_factions(name)
        local o_factions = factions.get_player_factions(meta:get_string("owner"))
        for _, o_faction in pairs(o_factions) do
            for _, p_faction in pairs(p_factions) do
                if o_faction == p_faction then return true end
            end
        end
	end

	for _, n in pairs(get_member_list(meta)) do

		if n == name then
			return true
		end
	end

	return false
end