@@ -13,50 +13,99 @@ jobs:
1313 runs-on : ubuntu-latest
1414 steps :
1515 - name : Checkout
16- uses : actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
16+ uses : actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
1717 with :
1818 fetch-depth : 0
1919 persist-credentials : false
2020
2121 - name : Get previous release
2222 id : previous_release
23- uses : actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 .0.0
23+ uses : actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9 .0.0
2424 env :
2525 CURRENT_TAG : ${{ github.event.release.tag_name }}
2626 with :
2727 script : |
2828 const currentTag = process.env.CURRENT_TAG;
2929
30- // Get all releases
31- const { data: releases } = await github.rest.repos.listReleases({
30+ // Paginate: with two release lines publishing interleaved, the
31+ // previous release on this line can sit far down the list.
32+ const releases = await github.paginate(github.rest.repos.listReleases, {
3233 owner: context.repo.owner,
3334 repo: context.repo.repo,
3435 per_page: 100
3536 });
3637
37- // Find current release index
38- const currentIndex = releases.findIndex(r => r.tag_name === currentTag);
39-
40- if (currentIndex === -1) {
38+ if (!releases.some(r => r.tag_name === currentTag)) {
4139 console.log('Current release not found in list');
4240 return null;
4341 }
4442
45- // Get previous release (next in the list since they're sorted by date desc)
46- const previousRelease = releases[currentIndex + 1];
43+ const major = tag => (tag.match(/^v?(\d+)/) || [])[1];
4744
48- if (!previousRelease ) {
49- console.log('No previous release found, this might be the first release' );
45+ if (major(currentTag) === undefined ) {
46+ console.log(`Cannot parse a major version from ${currentTag}; skipping comments` );
5047 return null;
5148 }
5249
53- console.log(`Found previous release: ${previousRelease.tag_name}`);
50+ // The list is ordered by release creation date, which does not
51+ // reliably reflect tag topology (for example, a release published
52+ // from a long-lived draft keeps its draft creation date). Instead
53+ // of trusting list order, compare every same-major release and
54+ // pick the nearest ancestor of the current tag: the one the
55+ // smallest number of commits behind it. The major check runs
56+ // first so cross-line candidates cost no API calls; per_page=1
57+ // because only status/ahead_by are needed here (the commits are
58+ // fetched in the next step). For the first release of a new major
59+ // line there is no same-line predecessor, and we skip commenting
60+ // rather than compare across the entire new line's history.
61+ let best = null;
62+ for (const candidate of releases) {
63+ if (candidate.tag_name === currentTag || candidate.draft) continue;
64+ if (major(candidate.tag_name) !== major(currentTag)) continue;
65+
66+ let comparison;
67+ try {
68+ ({ data: comparison } = await github.rest.repos.compareCommits({
69+ owner: context.repo.owner,
70+ repo: context.repo.repo,
71+ base: candidate.tag_name,
72+ head: currentTag,
73+ per_page: 1
74+ }));
75+ } catch (error) {
76+ // Tolerate only candidates whose tag no longer resolves;
77+ // anything else (rate limits, server errors) must fail the
78+ // job rather than silently produce a wrong comparison base.
79+ if (error.status === 404) {
80+ console.log(`Skipping ${candidate.tag_name}: tag does not resolve`);
81+ continue;
82+ }
83+ throw error;
84+ }
85+
86+ // 'identical' covers a release re-cut on the same commit; it
87+ // yields an empty commit range downstream, hence no comments.
88+ if (comparison.status !== 'ahead' && comparison.status !== 'identical') {
89+ console.log(`Skipping ${candidate.tag_name}: not an ancestor of ${currentTag} (status: ${comparison.status})`);
90+ continue;
91+ }
92+
93+ if (best === null || comparison.ahead_by < best.aheadBy) {
94+ best = { tagName: candidate.tag_name, aheadBy: comparison.ahead_by };
95+ }
96+ }
97+
98+ if (best === null) {
99+ console.log(`No previous release found for ${currentTag} on its major line (it may be the first); skipping comments`);
100+ return null;
101+ }
54102
55- return previousRelease.tag_name;
103+ console.log(`Found previous release: ${best.tagName} (${best.aheadBy} commits behind ${currentTag})`);
104+ return best.tagName;
56105
57106name : Get merged PRs between releases
58107 id : get_prs
59- uses : actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 .0.0
108+ uses : actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9 .0.0
60109 env :
61110 CURRENT_TAG : ${{ github.event.release.tag_name }}
62111 PREVIOUS_TAG_JSON : ${{ steps.previous_release.outputs.result }}
@@ -72,15 +121,28 @@ jobs:
72121
73122 console.log(`Finding PRs between ${previousTag} and ${currentTag}`);
74123
75- // Get commits between previous and current release
76- const comparison = await github.rest.repos.compareCommits({
77- owner: context.repo.owner,
78- repo: context.repo.repo,
79- base: previousTag,
80- head: currentTag
81- });
82-
83- const commits = comparison.data.commits;
124+ // Get commits between previous and current release. A single
125+ // compare response caps the commit list, so paginate — but bound
126+ // the total: a range this large means a mis-selected base, and
127+ // commenting on hundreds of PRs is worse than commenting on none.
128+ const MAX_COMMITS = 250;
129+ const commits = [];
130+ for (let page = 1; ; page++) {
131+ const { data: comparison } = await github.rest.repos.compareCommits({
132+ owner: context.repo.owner,
133+ repo: context.repo.repo,
134+ base: previousTag,
135+ head: currentTag,
136+ per_page: 100,
137+ page
138+ });
139+ commits.push(...comparison.commits);
140+ if (commits.length > MAX_COMMITS) {
141+ console.log(`Range ${previousTag}...${currentTag} exceeds ${MAX_COMMITS} commits; skipping comments`);
142+ return [];
143+ }
144+ if (comparison.commits.length < 100) break;
145+ }
84146 console.log(`Found ${commits.length} commits`);
85147
86148 // Get PRs associated with each commit using GitHub API
@@ -109,33 +171,41 @@ jobs:
109171 return Array.from(prNumbers);
110172
111173name : Comment on PRs
112- uses : actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 .0.0
174+ uses : actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9 .0.0
113175 env :
114176 PR_NUMBERS_JSON : ${{ steps.get_prs.outputs.result }}
115177 RELEASE_TAG : ${{ github.event.release.tag_name }}
116178 RELEASE_URL : ${{ github.event.release.html_url }}
179+ RELEASE_IS_PRERELEASE : ${{ github.event.release.prerelease }}
117180 with :
118181 script : |
119182 const prNumbers = JSON.parse(process.env.PR_NUMBERS_JSON);
120183 const releaseTag = process.env.RELEASE_TAG;
121184 const releaseUrl = process.env.RELEASE_URL;
185+ // Trust the tag as well as the flag, in case the release manager
186+ // forgets to tick the pre-release checkbox.
187+ const isPrerelease = process.env.RELEASE_IS_PRERELEASE === 'true' || /\d(a|b|rc)\d/.test(releaseTag);
188+ const releaseKind = isPrerelease ? 'pre-release' : 'release';
122189
123- const comment = `This pull request is included in [${releaseTag}](${releaseUrl})`;
190+ const comment = `This pull request is included in ${releaseKind} [${releaseTag}](${releaseUrl})`;
124191
125192 let commentedCount = 0;
126193
127194 for (const prNumber of prNumbers) {
128195 try {
129- // Check if we've already commented on this PR for this release
130- const { data: comments } = await github.rest.issues.listComments({
196+ // Check if we've already commented on this PR for this
197+ // release. Paginate: comments are returned oldest-first, so
198+ // on a busy PR an earlier bot comment is exactly what would
199+ // fall off a single page.
200+ const comments = await github.paginate(github.rest.issues.listComments, {
131201 owner: context.repo.owner,
132202 repo: context.repo.repo,
133203 issue_number: prNumber,
134204 per_page: 100
135205 });
136206
137207 const alreadyCommented = comments.some(c =>
138- c.user.type === 'Bot' && c.body.includes(releaseTag)
208+ c.user.type === 'Bot' && c.body.includes(`[${ releaseTag}]` )
139209 );
140210
141211 if (alreadyCommented) {
0 commit comments