From e3785f25990830568aeb8efedb76782463930983 Mon Sep 17 00:00:00 2001 From: Andrei Hasna Date: Mon, 6 Jul 2026 16:44:15 +0300 Subject: [PATCH] docs(codewith): point MCP guidance at connection_manager.rs The MCP tool-call guidance referenced a non-existent file codex-rs/codex-mcp/src/mcp_connection_manager.rs. The actual module defining McpConnectionManager is codex-rs/codex-mcp/src/connection_manager.rs. Update the pointer so contributors route MCP tool/tool-call mutation through the real connection manager abstraction. Co-Authored-By: Claude Opus 4.8 --- .codewith/CODEWITH.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codewith/CODEWITH.md b/.codewith/CODEWITH.md index ac23f5b9bd..d4d60ce7a0 100644 --- a/.codewith/CODEWITH.md +++ b/.codewith/CODEWITH.md @@ -50,7 +50,7 @@ In the codex-rs folder where the rust code lives: - Do not add general product or user-facing documentation to the `docs/` folder. The official Codewith documentation lives elsewhere. The exception is app-server API documentation, which is covered by the app-server guidance below. - Prefer private modules and explicitly exported public crate API. - If you change `ConfigToml` or nested config types, run `just write-config-schema` to update `codex-rs/core/config.schema.json`. -- When working with MCP tool calls, prefer using `codex-rs/codex-mcp/src/mcp_connection_manager.rs` to handle mutation of tools and tool calls. Aim to minimize the footprint of changes and leverage existing abstractions rather than plumbing code through multiple levels of function calls. +- When working with MCP tool calls, prefer using `codex-rs/codex-mcp/src/connection_manager.rs` to handle mutation of tools and tool calls. Aim to minimize the footprint of changes and leverage existing abstractions rather than plumbing code through multiple levels of function calls. - Do not call `reset_client_session` unnecessarily; let the incremental check logic decide whether to reuse the previous request. - If you change Rust dependencies (`Cargo.toml` or `Cargo.lock`), run `just bazel-lock-update` from the repo root to refresh `MODULE.bazel.lock`, and include that lockfile update in the same change.