From 13d9314460765b5b6c87452b9e3a5e52ff4f7c81 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 16 Jul 2026 13:15:38 +0000 Subject: [PATCH] test: fix vacuous assertion in queue_build test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit test_validation_accepts_minimal_params only checked is_ok() without verifying the result content. Strengthen it to assert on name, pipeline_id, branch, and reason — the properties that should be preserved verbatim by the infallible conversion path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/safe_outputs/queue_build.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/safe_outputs/queue_build.rs b/src/safe_outputs/queue_build.rs index 7f8f3225..9c58873e 100644 --- a/src/safe_outputs/queue_build.rs +++ b/src/safe_outputs/queue_build.rs @@ -398,8 +398,11 @@ mod tests { parameters: None, reason: None, }; - let result: Result = params.try_into(); - assert!(result.is_ok()); + let result: QueueBuildResult = params.try_into().expect("minimal params should succeed"); + assert_eq!(result.name, "queue-build"); + assert_eq!(result.pipeline_id, 1); + assert!(result.branch.is_none()); + assert!(result.reason.is_none()); } #[test]