From 3a0eaf8f52ff5c869da3711e843a5d042f9852b9 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed, 15 Jul 2026 09:18:15 +0000
Subject: [PATCH] docs: add trigger-e2e harness and export-fact-catalog to
 architecture tree and CLI reference

- Add trigger-e2e/ to AGENTS.md architecture tree (missing after #1504 added
  the deterministic gate/synth-PR E2E suite)
- Add export-fact-catalog to docs/cli.md hidden build-time tools section
  (parallel to export-gate-schema; generates fact-catalog.gen.json consumed
  by trigger-e2e/)
- Update AGENTS.md CLI description to mention export-fact-catalog alongside
  export-gate-schema

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 AGENTS.md   | 3 ++-
 docs/cli.md | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/AGENTS.md b/AGENTS.md
index 41667fac..00ba09ce 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -268,6 +268,7 @@ fail-closed and only pauses when the agent actually proposed a reviewed output.
 │           ├── approval-summary/ # Safe-outputs summary renderer (bundled to approval-summary.js; end-of-Agent-job summary tab)
 │           ├── github-app-token/ # GitHub App token minter (bundled to github-app-token.js; mints installation token in Agent + Detection when engine.github-app-token is set)
 │           ├── executor-e2e/ # Stage 3 safe-output E2E test harness (not a bundle; runs deterministic scenarios against a real ADO project and files a GitHub issue on failure)
+│           ├── trigger-e2e/ # Gate/synth-PR trigger-condition E2E harness (not a bundle; queues victim pipelines under real trigger conditions, asserts gate decisions, and files a GitHub issue on failure; uses fact-catalog.gen.json generated by `export-fact-catalog`)
 │           ├── prepare-pr-base/ # create-pull-request base-ref preparer (bundled to prepare-pr-base.js; fetches/deepens target branch so mcp.rs finds a diff base on shallow-default pools — issue #1413; emitted in BOTH the Agent job and the SafeOutputs job before the executor's worktree add — issue #1453)
 │           └── shared/   # Shared modules across bundles (auth, ado-client, env-facts, types.gen.ts)
 ├── tests/                # Integration tests and fixtures
@@ -353,7 +354,7 @@ index to jump to the right page.
   `check`, `mcp`, `mcp-http`, `execute`, `secrets`, `enable`, `disable`,
   `remove`, `list`, `status`, `run`, `audit`, `mcp-author`, `trace`,
   `inspect`, `graph`, `whatif`, `lint`, `catalog`; `configure` is a
-  deprecated hidden alias and `export-gate-schema` is a hidden build-time tool).
+  deprecated hidden alias and `export-gate-schema` and `export-fact-catalog` are hidden build-time tools).
 - [`docs/agency-plugin.md`](docs/agency-plugin.md) — the Agency / Claude Code
   plugin (`agency/plugins/ado-aw/`): canonical layout, six skills, `mcp-author`
   wiring, the self-contained root marketplace catalogs, `init --agency`
diff --git a/docs/cli.md b/docs/cli.md
index 4bc2dbe7..9301d814 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -187,6 +187,10 @@ These commands are not shown in `--help` but are available for contributors work
   - `--output, -o <path>` - Write the schema to a file instead of stdout. Parent directories are created automatically.
   - See [`docs/ado-script.md`](ado-script.md) for how this command fits into the ado-script build workflow (`cargo run -- export-gate-schema --output schema/gate-spec.schema.json`).
 
+- `export-fact-catalog` - Export a JSON catalog of every gate `Fact` (kind, failure policy, dependencies). Used as a build-time drift guard: the `scripts/ado-script/src/trigger-e2e/` harness mirrors the output as `fact-catalog.gen.json` so TypeScript-side gate logic stays in sync with the Rust `filter_ir` definitions.
+  - `--output, -o <path>` - Write the catalog to a file instead of stdout. Parent directories are created automatically.
+  - Usage: `cargo run -- export-fact-catalog --output scripts/ado-script/src/trigger-e2e/fact-catalog.gen.json`
+
 ## Pipeline IR Reference
 
 The compiler builds typed Azure DevOps pipeline IR and lowers it through one YAML emitter. The canonical Setup → Agent → Detection → SafeOutputs → Teardown shape, plus the optional always-running Conclusion job when `safe-outputs:` is configured, lives in `agentic_pipeline.rs` (shared by every target); target-specific builders (`standalone_ir.rs`, `onees_ir.rs`, `job_ir.rs`, and `stage_ir.rs`) own only the per-target envelope (pipeline shape, template parameters, 1ES wrapping).