Fix foreign key crash when opening an unknown asset#373
Merged
Conversation
Opening an asset that is not in the wallet's local DB crashed with SQLiteConstraintException: FOREIGN KEY constraint failed. updateAssetMetadata used Room @update for the asset row, which is a no-op when the row does not exist, then inserted asset_market with a foreign key to the missing asset. Persist the fetched AssetFull as one atomic aggregate: upsert the asset root first, then links and market in a single @transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an asset that isn't in the wallet's local DB crashed with
SQLiteConstraintException: FOREIGN KEY constraint failed.updateAssetMetadataran Room@Updateon the asset row — a no-op whenthe row doesn't exist — then inserted
asset_marketreferencing themissing asset.
The fetched
AssetFullis now persisted as one atomic aggregate: theasset root is upserted first, then links and market in a single
@Transaction.Closes #372