[google_maps_flutter] Add onPointOfInterestTap callback#11872
Draft
tenninebt wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
p: google_maps_flutter
platform-android
platform-ios
platform-web
labels
tenninebt
force-pushed
the
google-maps-on-poi-tap
branch
2 times, most recently
from
1e9a709 to
36fa34c
Compare
Expose a place-ID-only POI tap stream across the federated plugin stack (Android, iOS, web) so apps can react when users tap built-in map POIs. Fixes flutter/flutter#60695
tenninebt
force-pushed
the
google-maps-on-poi-tap
branch
from
36fa34c to
157aaa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
GoogleMap.onPointOfInterestTap, a callback that fires when the user taps a built-in map point of interest. The callback receives aPointOfInterestIdcontaining the place ID only, matching maintainer feedback on #4052 and #10963.The change is wired through the federated plugin stack: platform_interface (type + event stream), Android (
OnPoiClickListener), iOS including sdk9/sdk10/shared (didTapPOIWithPlaceID), web (IconMouseEvent.placeIdon map click), and the app-facinggoogle_maps_flutterpackage. Tests cover Dart unit tests, Android Robolectric, iOS native, and web integration tests in the web example.Fixes flutter/flutter#60695
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2