dt 5.6: updating additional scripts

[deekayhd]

I am not sure if this is a bug/missing functionality or just a user error, but I am wondering how the installation and update of additional scripts from other repositories works in 5.6.
In the scripts module on the "install/update scripts" action screen you can enter a git repository URL to download additional scripts. This also works in 5.6: A new subfolder is created in the lua folder of the configdir.
However, when clicking on "update scripts" after selecting the new folder in the dropdown box, I get a message in the log:

fatal: not a git repository (or any of the parent directories): .git

because the script manager executes a git pull in the configdir lua folder, (independent of the setting of the dropdown box), but in 5.6 this is not necessarily a git folder.
In 5.4, the pull worked, but it did not pull from the repo for the additional scripts. but from https://github.com/darktable-org/lua-scripts.git.

My proposal is to change line 796 of script_manager.lua to

local git_command = "cd " .. sm.installed_repositories[sm.widgets.update_script_choices.selected].directory .. " " .. CS .. " " .. git .. " pull"

Is my understanding correct?

[wpferguson]

Create a lua subdirectory in your config directory and try again. If the lua subdirectory is there then adding additional scripts works fine.

EDIT: I'll add a check for the lua subdirectory and add it if it doesn't exist

[deekayhd]

@wpferguson sorry, if I did not make it clear enough, but adding the scripts is not the problem. I tried to explain that updating them does not work. The script manager executes a git pull, but in the wrong directory.