You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removes the legacy REST POST /upload endpoint from graphql/server.
This endpoint used a separate upload-specific auth path, multer parsing, and streamToStorage() helper. Upload flows should now use GraphQL-backed paths instead of deriving /upload from a GraphQL endpoint.
Changes
Removed graphql/server/src/middleware/upload.ts
createUploadAuthenticateMiddleware
uploadRoute
multer-based file parsing
upload-specific RLS/auth fallback logic
Removed /upload route registration from graphql/server/src/server.ts
Removed upload middleware exports from graphql/server/src/index.ts
Removed streamToStorage() from graphile-settings
Removed now-unused server dependencies:
multer
@types/multer
@pgsql/quotes
@constructive-io/upload-names
Deleted legacy upload middleware tests
Updated upload architecture docs to reflect the REST endpoint removal
Added dashboard follow-up notes for known /upload consumers in packages/sheets
Dashboard Follow-Up
Dashboard still has runtime code that derives /upload from /graphql, mainly in the sheets upload flow. This PR documents that impact in:
That dashboard work should migrate to a GraphQL-backed upload path separately.
Notes
This PR intentionally does not change the GraphQL multipart upload implementation or presigned upload flows. It only removes the historical REST upload endpoint and related dead server code.
Next steps: Take a moment to review the security alert above. Review
the linked package source code to understand the potential risk. Ensure the
package is not malicious before proceeding. If you're unsure how to proceed,
reach out to your security team or ask the Socket team for help at
support@socket.dev.
Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.
Mark the package as acceptable risk. To ignore this alert only
in this pull request, reply with the comment
@SocketSecurity ignore npm/@launchql/protobufjs@7.2.6. You can
also ignore all packages with @SocketSecurity ignore-all.
To ignore an alert for all future pull requests, use Socket's Dashboard to
change the triage state of this alert.
Warn
Obfuscated code: npm @noble/hashes is 90.0% likely obfuscated
Next steps: Take a moment to review the security alert above. Review
the linked package source code to understand the potential risk. Ensure the
package is not malicious before proceeding. If you're unsure how to proceed,
reach out to your security team or ask the Socket team for help at
support@socket.dev.
Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.
Mark the package as acceptable risk. To ignore this alert only
in this pull request, reply with the comment
@SocketSecurity ignore npm/@noble/hashes@1.8.0. You can
also ignore all packages with @SocketSecurity ignore-all.
To ignore an alert for all future pull requests, use Socket's Dashboard to
change the triage state of this alert.
Warn
Obfuscated code: npm @noble/hashes is 90.0% likely obfuscated
Next steps: Take a moment to review the security alert above. Review
the linked package source code to understand the potential risk. Ensure the
package is not malicious before proceeding. If you're unsure how to proceed,
reach out to your security team or ask the Socket team for help at
support@socket.dev.
Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.
Mark the package as acceptable risk. To ignore this alert only
in this pull request, reply with the comment
@SocketSecurity ignore npm/@noble/hashes@1.8.0. You can
also ignore all packages with @SocketSecurity ignore-all.
To ignore an alert for all future pull requests, use Socket's Dashboard to
change the triage state of this alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the legacy REST
POST /uploadendpoint fromgraphql/server.This endpoint used a separate upload-specific auth path,
multerparsing, andstreamToStorage()helper. Upload flows should now use GraphQL-backed paths instead of deriving/uploadfrom a GraphQL endpoint.Changes
graphql/server/src/middleware/upload.tscreateUploadAuthenticateMiddlewareuploadRoute/uploadroute registration fromgraphql/server/src/server.tsgraphql/server/src/index.tsstreamToStorage()fromgraphile-settingsmulter@types/multer@pgsql/quotes@constructive-io/upload-names/uploadconsumers inpackages/sheetsDashboard Follow-Up
Dashboard still has runtime code that derives
/uploadfrom/graphql, mainly in the sheets upload flow. This PR documents that impact in:graphile/graphile-upload-plugin/DASHBOARD_UPLOAD_FOLLOWUP.mdThat dashboard work should migrate to a GraphQL-backed upload path separately.
Notes
This PR intentionally does not change the GraphQL multipart upload implementation or presigned upload flows. It only removes the historical REST upload endpoint and related dead server code.