C++ out-of-line static method definitions are missing the outer namespace in qualifiedName, breaking caller resolution for ns::Class::Method(...) calls

[Cecil-Huang]

Version
1.4.1 (re-indexed with codegraph index -f after upgrading from 0.9.9 — v1.3.0's namespace-qualified-call fix (mentioned in CHANGELOG.md, "namespace-qualified calls (ns::fn(...)) resolve to their definitions") does NOT cover this specific case)

Repro shape
// manifest_startup.h
namespace simulator {
class ManifestStartup {
public:
struct Input { /* ... / };
struct Output { / ... */ };
static Output Apply(const Input& input);
};
} // namespace simulator
// manifest_startup.cpp
namespace simulator {
ManifestStartup::Output ManifestStartup::Apply(const Input& input) {
// ...
}
} // namespace simulator
// main.cpp (different file)
const auto manifest_result = simulator::ManifestStartup::Apply({ ... });
Observed
codegraph query "ManifestStartup" correctly resolves the class and its nested types with the full namespace:

"kind": "class", "qualifiedName": "simulator::ManifestStartup"
"kind": "struct", "qualifiedName": "simulator::ManifestStartup::Input"
"kind": "struct", "qualifiedName": "simulator::ManifestStartup::Output"
But the out-of-line method definition is indexed without the outer namespace:

"kind": "method", "qualifiedName": "ManifestStartup::Apply"
(missing the simulator:: prefix that the class and nested structs both have).

As a result:

codegraph callers "ManifestStartup::Apply" --json → {"callers": []}
codegraph impact "simulator/core/src/manifest_startup.cpp" --json → edgeCount: 0
codegraph callers "Apply" --json --limit 200 (unqualified, broad) → the real caller file never appears in the result set at all
despite the call site being real and unambiguous (confirmed via plain grep).

Expected
The out-of-line method definition's qualifiedName should carry the same namespace prefix as the class/nested-type symbols it belongs to (simulator::ManifestStartup::Apply), and the call-site resolution added in v1.3.0 for ns::fn(...) should link through consistently for this pattern too.

Context
Found while validating a mechanical cross-check that compares an architecture-model declaration ("component A calls component B") against codegraph's real call graph. The broad namespace-qualified-call fix in v1.3.0 works correctly for plain free functions in a namespace; this narrower case (nested namespace + out-of-line static method definition, called via the fully-qualified path from another file) still doesn't link.

[colbymchenry]

Fixed in #1310 (merged to main, ships in the next release).

Root cause: an out-of-line member definition takes its qualified name from the declarator's receiver, which C++ spells relative to the enclosing namespace — so inside namespace simulator { ... }, ManifestStartup::Apply was stored without the prefix while the class node (built from the namespace stack) correctly carried simulator::ManifestStartup. Your fully-qualified call site then had nothing to match. This is why the v1.3.0 fix didn't cover it: that one taught call sites to resolve ns::fn(...), but this definition-side name never said simulator:: at all.

Your exact three-file repro (nested Input/Output, out-of-line static Apply in the .cpp, qualified call from main.cpp) is now an end-to-end regression test asserting both the qualified name and that codegraph callers finds the caller. Also handled: the legal re-spelled form (namespace sim { void sim::M::f() {} }) doesn't double-prefix.

On google/leveldb this promoted 305 out-of-line method definitions to their correct namespace-qualified names with the node count byte-stable.

After upgrading, codegraph index -f rebuilds the names — your architecture-model cross-check should then see the real call graph. That's a great validation workload, happy to hear what else it surfaces.