From 2a68e95647cdfb388dfc9bfaf710384dcb33e9e0 Mon Sep 17 00:00:00 2001 From: Brian Love Date: Wed, 8 Jul 2026 08:06:54 -0700 Subject: [PATCH] chore(ci): remove placeholder cockpit secret gate --- .github/workflows/ci.yml | 37 ------------------- .../deployment-runtime/python/project.json | 7 ---- libs/a2ui/project.json | 1 - libs/ag-ui/project.json | 1 - libs/ag-ui/src/lib/testing/fake-agent.ts | 1 - libs/chat/project.json | 1 - .../cockpit-registry/src/lib/manifest.spec.ts | 6 +-- libs/cockpit-registry/src/lib/manifest.ts | 15 +------- libs/langgraph/project.json | 1 - libs/licensing/project.json | 1 - libs/render/project.json | 1 - libs/telemetry/project.json | 1 - scripts/ci-scope.mjs | 2 +- scripts/ci-scope.spec.mjs | 11 ++---- scripts/ci-workflow.spec.mjs | 1 - 15 files changed, 10 insertions(+), 77 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e71ac73fd..e75e466da 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,7 +26,6 @@ jobs: cockpit: ${{ steps.scope.outputs.cockpit }} cockpit_examples: ${{ steps.scope.outputs.cockpit_examples }} cockpit_smoke: ${{ steps.scope.outputs.cockpit_smoke }} - cockpit_secret: ${{ steps.scope.outputs.cockpit_secret }} cockpit_deploy_smoke: ${{ steps.scope.outputs.cockpit_deploy_smoke }} examples_chat: ${{ steps.scope.outputs.examples_chat }} cockpit_e2e: ${{ steps.scope.outputs.cockpit_e2e }} @@ -198,37 +197,6 @@ jobs: - run: npm ci - run: npx nx run-many -t smoke --projects=cockpit-ag-ui-interrupts-python,cockpit-ag-ui-streaming-python,cockpit-deep-agents-planning-python,cockpit-deep-agents-filesystem-python,cockpit-deep-agents-subagents-python,cockpit-deep-agents-memory-python,cockpit-deep-agents-skills-python,cockpit-deep-agents-sandboxes-python,cockpit-langgraph-persistence-python,cockpit-langgraph-durable-execution-python,cockpit-langgraph-streaming-python,cockpit-langgraph-interrupts-python,cockpit-langgraph-memory-python,cockpit-langgraph-subgraphs-python,cockpit-langgraph-time-travel-python,cockpit-langgraph-deployment-runtime-python,cockpit-chat-messages-python,cockpit-render-spec-rendering-python --skip-nx-cache - cockpit-secret-integration: - name: Cockpit — secret-gated integration - needs: ci-scope - if: github.event_name == 'push' || needs.ci-scope.outputs.cockpit_secret == 'true' - runs-on: ubuntu-latest - steps: - - name: Check integration secret - id: integration_secret - run: | - if [ -z "${COCKPIT_SECRET_TOKEN}" ]; then - echo "enabled=false" >> "$GITHUB_OUTPUT" - echo "::notice::Skipping secret-gated integration: COCKPIT_SECRET_TOKEN is not configured" - else - echo "enabled=true" >> "$GITHUB_OUTPUT" - fi - env: - COCKPIT_SECRET_TOKEN: ${{ secrets.COCKPIT_SECRET_TOKEN }} - - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - if: steps.integration_secret.outputs.enabled == 'true' - - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 - if: steps.integration_secret.outputs.enabled == 'true' - with: - node-version: 22 - cache: npm - - if: steps.integration_secret.outputs.enabled == 'true' - run: npm ci - - if: steps.integration_secret.outputs.enabled == 'true' - run: npx nx run cockpit-langgraph-deployment-runtime-python:integration --skip-nx-cache - env: - COCKPIT_SECRET_TOKEN: ${{ secrets.COCKPIT_SECRET_TOKEN }} - cockpit-deploy-smoke: name: Cockpit — deploy smoke dry-run timeout-minutes: 30 # fail fast instead of blocking the main concurrency group on a hang @@ -505,7 +473,6 @@ jobs: - cockpit - cockpit-examples-build - cockpit-smoke - - cockpit-secret-integration - cockpit-deploy-smoke - examples-chat-smoke - examples-chat-e2e @@ -523,7 +490,6 @@ jobs: RESULT_COCKPIT: ${{ needs.cockpit.result }} RESULT_COCKPIT_EXAMPLES: ${{ needs.cockpit-examples-build.result }} RESULT_COCKPIT_SMOKE: ${{ needs.cockpit-smoke.result }} - RESULT_COCKPIT_SECRET: ${{ needs.cockpit-secret-integration.result }} RESULT_COCKPIT_DEPLOY_SMOKE: ${{ needs.cockpit-deploy-smoke.result }} RESULT_EXAMPLES_CHAT_SMOKE: ${{ needs.examples-chat-smoke.result }} RESULT_EXAMPLES_CHAT_E2E: ${{ needs.examples-chat-e2e.result }} @@ -535,7 +501,6 @@ jobs: SCOPE_COCKPIT: ${{ needs.ci-scope.outputs.cockpit }} SCOPE_COCKPIT_EXAMPLES: ${{ needs.ci-scope.outputs.cockpit_examples }} SCOPE_COCKPIT_SMOKE: ${{ needs.ci-scope.outputs.cockpit_smoke }} - SCOPE_COCKPIT_SECRET: ${{ needs.ci-scope.outputs.cockpit_secret }} SCOPE_COCKPIT_DEPLOY_SMOKE: ${{ needs.ci-scope.outputs.cockpit_deploy_smoke }} SCOPE_EXAMPLES_CHAT: ${{ needs.ci-scope.outputs.examples_chat }} SCOPE_COCKPIT_E2E: ${{ needs.ci-scope.outputs.cockpit_e2e }} @@ -582,7 +547,6 @@ jobs: require_scoped "cockpit" "Cockpit — build / test" "$RESULT_COCKPIT" "$SCOPE_COCKPIT" require_scoped "cockpit_examples" "Cockpit — build all examples" "$RESULT_COCKPIT_EXAMPLES" "$SCOPE_COCKPIT_EXAMPLES" require_scoped "cockpit_smoke" "Cockpit — representative capability smoke" "$RESULT_COCKPIT_SMOKE" "$SCOPE_COCKPIT_SMOKE" - require_scoped "cockpit_secret" "Cockpit — secret-gated integration" "$RESULT_COCKPIT_SECRET" "$SCOPE_COCKPIT_SECRET" require_scoped "cockpit_deploy_smoke" "Cockpit — deploy smoke dry-run" "$RESULT_COCKPIT_DEPLOY_SMOKE" "$SCOPE_COCKPIT_DEPLOY_SMOKE" require_scoped "examples_chat" "examples/chat — python smoke" "$RESULT_EXAMPLES_CHAT_SMOKE" "$SCOPE_EXAMPLES_CHAT" require_scoped "examples_chat" "examples/chat — e2e" "$RESULT_EXAMPLES_CHAT_E2E" "$SCOPE_EXAMPLES_CHAT" @@ -606,7 +570,6 @@ jobs: cockpit, cockpit-examples-build, cockpit-smoke, - cockpit-secret-integration, cockpit-deploy-smoke, examples-chat-smoke, examples-chat-e2e, diff --git a/cockpit/langgraph/deployment-runtime/python/project.json b/cockpit/langgraph/deployment-runtime/python/project.json index 007fb2170..a1ef5c87d 100644 --- a/cockpit/langgraph/deployment-runtime/python/project.json +++ b/cockpit/langgraph/deployment-runtime/python/project.json @@ -21,13 +21,6 @@ "cwd": "cockpit/langgraph/deployment-runtime/python", "command": "npx tsx -e \"import { langgraphDeploymentRuntimePythonModule } from './src/index.ts'; const module = langgraphDeploymentRuntimePythonModule; if (module.id !== 'langgraph-deployment-runtime-python' || module.title !== 'LangGraph Deployment Runtime (Python)') { throw new Error('Unexpected module shape for ' + module.id); }\"" } - }, - "integration": { - "executor": "nx:run-commands", - "options": { - "cwd": "cockpit/langgraph/deployment-runtime/python", - "command": "npx tsx -e \"const token = process.env.COCKPIT_SECRET_TOKEN; if (!token) { throw new Error('Missing COCKPIT_SECRET_TOKEN'); } console.log('secret-gated integration ready');\"" - } } }, "tags": [ diff --git a/libs/a2ui/project.json b/libs/a2ui/project.json index 0b51ffc57..7e0a34553 100644 --- a/libs/a2ui/project.json +++ b/libs/a2ui/project.json @@ -8,7 +8,6 @@ "scope:cockpit-deploy-smoke", "scope:cockpit-e2e", "scope:cockpit-examples", - "scope:cockpit-secret", "scope:cockpit-smoke", "scope:examples-chat", "scope:library", diff --git a/libs/ag-ui/project.json b/libs/ag-ui/project.json index c000bb579..eb29843c4 100644 --- a/libs/ag-ui/project.json +++ b/libs/ag-ui/project.json @@ -9,7 +9,6 @@ "scope:cockpit-deploy-smoke", "scope:cockpit-e2e", "scope:cockpit-examples", - "scope:cockpit-secret", "scope:cockpit-smoke", "scope:examples-chat", "scope:library", diff --git a/libs/ag-ui/src/lib/testing/fake-agent.ts b/libs/ag-ui/src/lib/testing/fake-agent.ts index 47603c0ed..6b9a68eb3 100644 --- a/libs/ag-ui/src/lib/testing/fake-agent.ts +++ b/libs/ag-ui/src/lib/testing/fake-agent.ts @@ -64,7 +64,6 @@ export class FakeAgent extends AbstractAgent { const tokens = this.tokens; const reasoningTokens = this.reasoningTokens; - const delayMs = this.delayMs; const messageId = `fake-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`; const sequence: BaseEvent[] = [ diff --git a/libs/chat/project.json b/libs/chat/project.json index ae4a6dac8..02335049a 100644 --- a/libs/chat/project.json +++ b/libs/chat/project.json @@ -9,7 +9,6 @@ "scope:cockpit-deploy-smoke", "scope:cockpit-e2e", "scope:cockpit-examples", - "scope:cockpit-secret", "scope:cockpit-smoke", "scope:examples-chat", "scope:library", diff --git a/libs/cockpit-registry/src/lib/manifest.spec.ts b/libs/cockpit-registry/src/lib/manifest.spec.ts index 81a4c0df0..aff5294d5 100644 --- a/libs/cockpit-registry/src/lib/manifest.spec.ts +++ b/libs/cockpit-registry/src/lib/manifest.spec.ts @@ -132,7 +132,7 @@ describe('cockpitManifest', () => { expect(aguiTopics).toEqual(expect.arrayContaining(['streaming', 'interrupts'])); }); - it('marks secret-gated integration explicitly for deployment runtime', () => { + it('does not advertise placeholder integration coverage for deployment runtime', () => { const deploymentRuntimeEntry = cockpitManifest.find( (entry) => entry.product === 'langgraph' && @@ -144,8 +144,8 @@ describe('cockpitManifest', () => { runtimeClass: 'deployed-service', testingContract: { smokeTarget: 'cockpit-langgraph-deployment-runtime-python:smoke', - integrationTarget: 'cockpit-langgraph-deployment-runtime-python:integration', - integrationMode: 'secret-gated', + integrationTarget: null, + integrationMode: 'none', deploySmokePath: '/langgraph/core-capabilities/deployment-runtime/overview/python', }, diff --git a/libs/cockpit-registry/src/lib/manifest.ts b/libs/cockpit-registry/src/lib/manifest.ts index de52390cf..505a91c8f 100644 --- a/libs/cockpit-registry/src/lib/manifest.ts +++ b/libs/cockpit-registry/src/lib/manifest.ts @@ -107,14 +107,6 @@ const getCodeAssetPath = (product: CockpitProduct, topic: string): string => const getSmokeTarget = (product: CockpitProduct, topic: string): string => `cockpit-${product}-${topic}-python:smoke`; -const getIntegrationTarget = ( - product: CockpitProduct, - topic: string -): string | null => - product === 'langgraph' && topic === 'deployment-runtime' - ? 'cockpit-langgraph-deployment-runtime-python:integration' - : null; - const getRuntimeClass = (topic: string): CockpitRuntimeClass => topic === 'deployment-runtime' ? 'deployed-service' : 'local-service'; @@ -163,11 +155,8 @@ const createEntry = ( deploymentStatus: 'planned', testingContract: { smokeTarget: isDocsOnly ? null : getSmokeTarget(product, topic), - integrationTarget: isDocsOnly ? null : getIntegrationTarget(product, topic), - integrationMode: - isDocsOnly || getIntegrationTarget(product, topic) === null - ? 'none' - : 'secret-gated', + integrationTarget: null, + integrationMode: 'none', deploySmokePath: `/${product}/${section}/${topic}/${page}/python`, }, }; diff --git a/libs/langgraph/project.json b/libs/langgraph/project.json index e2d1ea50b..a48009982 100644 --- a/libs/langgraph/project.json +++ b/libs/langgraph/project.json @@ -9,7 +9,6 @@ "scope:cockpit-deploy-smoke", "scope:cockpit-e2e", "scope:cockpit-examples", - "scope:cockpit-secret", "scope:cockpit-smoke", "scope:examples-chat", "scope:library", diff --git a/libs/licensing/project.json b/libs/licensing/project.json index fe88b19c9..24d2484ae 100644 --- a/libs/licensing/project.json +++ b/libs/licensing/project.json @@ -8,7 +8,6 @@ "scope:cockpit-deploy-smoke", "scope:cockpit-e2e", "scope:cockpit-examples", - "scope:cockpit-secret", "scope:cockpit-smoke", "scope:examples-chat", "scope:library", diff --git a/libs/render/project.json b/libs/render/project.json index 7a6c8eaa8..037a5587b 100644 --- a/libs/render/project.json +++ b/libs/render/project.json @@ -9,7 +9,6 @@ "scope:cockpit-deploy-smoke", "scope:cockpit-e2e", "scope:cockpit-examples", - "scope:cockpit-secret", "scope:cockpit-smoke", "scope:examples-chat", "scope:library", diff --git a/libs/telemetry/project.json b/libs/telemetry/project.json index 21ca5ea52..aa19f576d 100644 --- a/libs/telemetry/project.json +++ b/libs/telemetry/project.json @@ -8,7 +8,6 @@ "scope:cockpit-deploy-smoke", "scope:cockpit-e2e", "scope:cockpit-examples", - "scope:cockpit-secret", "scope:cockpit-smoke", "scope:examples-chat", "scope:library", diff --git a/scripts/ci-scope.mjs b/scripts/ci-scope.mjs index 65339be38..e94f9be44 100644 --- a/scripts/ci-scope.mjs +++ b/scripts/ci-scope.mjs @@ -7,7 +7,7 @@ import { fileURLToPath } from 'node:url'; export const SCOPE_KEYS = [ 'library', 'website', 'website_e2e', 'cockpit', 'cockpit_examples', 'cockpit_smoke', - 'cockpit_secret', 'cockpit_deploy_smoke', 'cockpit_e2e', + 'cockpit_deploy_smoke', 'cockpit_e2e', 'examples_chat', 'posthog', ]; diff --git a/scripts/ci-scope.spec.mjs b/scripts/ci-scope.spec.mjs index 47ece4b3c..42cc7c81e 100644 --- a/scripts/ci-scope.spec.mjs +++ b/scripts/ci-scope.spec.mjs @@ -11,8 +11,7 @@ import { const PUBLISHABLE_LIB_TAGS = [ 'scope:library', 'scope:website', 'scope:website-e2e', 'scope:cockpit', 'scope:cockpit-examples', 'scope:cockpit-smoke', - 'scope:cockpit-secret', 'scope:cockpit-deploy-smoke', - 'scope:cockpit-e2e', 'scope:examples-chat', + 'scope:cockpit-deploy-smoke', 'scope:cockpit-e2e', 'scope:examples-chat', ]; const COCKPIT_CAP_ANGULAR_TAGS = ['scope:cockpit-examples', 'scope:cockpit-e2e']; const COCKPIT_CAP_PYTHON_TAGS = ['scope:cockpit-examples', 'scope:cockpit-e2e', 'scope:cockpit-smoke']; @@ -44,12 +43,11 @@ describe('classifyFromAffected — lint-only files', () => { assert.equal(scope.cockpit, true); assert.equal(scope.website, true); assert.equal(scope.examples_chat, true); - // E2e / smoke / deploy / secret / posthog scopes: false + // E2e / smoke / deploy / posthog scopes: false assert.equal(scope.website_e2e, false); assert.equal(scope.cockpit_e2e, false); assert.equal(scope.cockpit_smoke, false); assert.equal(scope.cockpit_examples, false); - assert.equal(scope.cockpit_secret, false); assert.equal(scope.cockpit_deploy_smoke, false); assert.equal(scope.posthog, false); }); @@ -77,7 +75,6 @@ describe('classifyFromAffected — publishable lib broadcast', () => { assert.equal(scope.cockpit, true); assert.equal(scope.cockpit_examples, true); assert.equal(scope.cockpit_smoke, true); - assert.equal(scope.cockpit_secret, true); assert.equal(scope.cockpit_deploy_smoke, true); assert.equal(scope.cockpit_e2e, true); assert.equal(scope.examples_chat, true); @@ -166,11 +163,11 @@ describe('classifyFromAffected — tag isolation', () => { }); describe('SCOPE_KEYS export', () => { - it('contains the 11 documented scope keys', () => { + it('contains the 10 documented scope keys', () => { assert.deepEqual(SCOPE_KEYS, [ 'library', 'website', 'website_e2e', 'cockpit', 'cockpit_examples', 'cockpit_smoke', - 'cockpit_secret', 'cockpit_deploy_smoke', 'cockpit_e2e', + 'cockpit_deploy_smoke', 'cockpit_e2e', 'examples_chat', 'posthog', ]); }); diff --git a/scripts/ci-workflow.spec.mjs b/scripts/ci-workflow.spec.mjs index da6baea68..0d62eec7a 100644 --- a/scripts/ci-workflow.spec.mjs +++ b/scripts/ci-workflow.spec.mjs @@ -176,7 +176,6 @@ describe('CI workflow', () => { 'cockpit', 'cockpit-examples-build', 'cockpit-smoke', - 'cockpit-secret-integration', 'cockpit-deploy-smoke', 'examples-chat-smoke', 'examples-chat-e2e',