Migrating some packages to TypeScript.

[bhavya3024]

Hi @voodootikigod @jeremyevans @dmnd @pshc @mikl are you planning to migrate completely to TypeScript ? If not I can raise a pull request for this as a contribution.
Thanks!

[jeremyevans]

I haven't used node in about a decade, so I'm not a good person to ask.

[brianc]

Migrating everything to typescript is something I'd love to do eventually....the main pg package is going to be the most nightmarish due to it using some more older coding styles and having about a bazillion unit/integration tests....some of which were written a long time ago when there weren't the same conventions around how things "are done" in node...so they're kinda a mess. Migrating pg-pool to typescript would be useful as I feel like that's 1) super heavily used 2) more self-contained 3) has a more modern test framework (mocha). Always down to review PRs for converting to typescript.....the smaller the PR the better (maybe start by migrating the tests in 1 PR and then the code in another or something?) Its just not as high priority right now as some other things for me but eventually would be cool to do as I really find TypeScript to be valuable.

[mschilde]

I'd be happy to help! Migrating legacy JS codebases gradually to TS is part of what I do for a living. Shall we make a project out of it and coordinate?

[yatoogamii]

Hi, is there any update about Typescript migration of pg/pg-pool package ?

[brianc]

its on my todo list! That list never seems to shrink though 😬 but i haven't abandoned the idea by any means. I've been chipping away at making the pg test suite (which is hellaciously old, but still valuable) a bit more updated so it wont make typescript so angry. I did a bunch of stuff long, long ago like extending node's assert and using global variables and import side effects. Been trying to reduce bit by bit, etc.

[yatoogamii]

Could we have a branch and/or an "Official" issue to track on this ? A little contribution by contribution we could achieve it

[bhavya3024]

Should we start doing this migrating ?

[productdevbook]

@brianc Would you like me to do this ?

[brianc]

I think that would be rad! As many or as few packages as you have time for. 😀

[productdevbook]

@brianc A PR is coming soon. It’ll be as clean as the libraries in my profile.

[productdevbook]

@brianc as promised, the RFC is up: #3664

End-to-end ESM/TypeScript migration of the whole monorepo (pg, pg-pool, pg-protocol, pg-cursor, pg-query-stream, pg-cloudflare, pg-connection-string, pg-native), pnpm workspaces, vitest, oxlint/oxfmt, Node 22+. 713/720 tests green against a dockerized postgres. Still actively iterating on the remaining failures and a few cleanups.

Happy to slice it into smaller per-package PRs if that's easier to review — just say the word.