Skip to content

[MRESOLVER-126] support conversion from String to Map for config#63

Open
kwin wants to merge 1 commit into
apache:masterfrom
kwin:feature/support-map-config-conversion
Open

[MRESOLVER-126] support conversion from String to Map for config#63
kwin wants to merge 1 commit into
apache:masterfrom
kwin:feature/support-map-config-conversion

Conversation

@kwin

@kwin kwin commented Jun 23, 2020

Copy link
Copy Markdown
Member

properties

@michael-o michael-o left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like pain. When you have code, you can pass a map, when you are at the command line, it will make the input unreadable. I really fail to see how somenoe will pass Java properties format via a single CLI.

@kwin

kwin commented Jun 28, 2020

Copy link
Copy Markdown
Member Author

At least for single entries this is good enough also to pass from CLI, e.g. -Daether.connector.http.headers.myrepo="custom-auth-header=customauthvalue". Multiple entries are a pain indeed, but should rarely occur. In any case this is better than before, IMHO. I cannot think of a good solution for multiple entries for CLI or do you have any proposal?

@michael-o

michael-o commented Jun 28, 2020

Copy link
Copy Markdown
Member

The only thing I can image is that String will contain a local path to a proprties file. But I really would put this issue aside until someone really complains that this does not work.

@jira-importer

Copy link
Copy Markdown

Resolve #859

1 similar comment
@jira-importer

Copy link
Copy Markdown

Resolve #859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants