feat(i18n): add Korean (ko) locale + extend CJK banner to ko#143
Merged
Conversation
Adds the seventh supported locale (en/ja/ko/nl/fr/bg/es). Machine- translated baseline flagged via _translator_notes — community polish via PR welcome, same convention as ja/nl/fr/bg/es. The CJK font install banner already had the locale-keyed dismissal state and per-locale script_label translation key in place from V2-267. This patch lights ko up the way the original ticket described as mechanical: - composables/useCjkFontBanner.ts: 'ko' joins CJK_LOCALES - locales/ko.json: script_label = "한국어"; install commands stay the same (noto-cjk is the unified Chinese/Japanese/Korean font, single package on every distro) - locales/ko.json: message body stays English by design — audience is Linux users whose CJK font is broken, so a Korean message would also render as tofu Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
한국어_translator_notes, same convention as ja / nl / fr / bg / eskofor free — the locale-keyed dismissal state and per-localescript_labeltranslation key were designed in for exactly this in feat(i18n): add CJK font install banner for Linux #139What's in the patch
locales/ko.json— full 373-key Korean baseline, ICU placeholders and special tokens preserved verbatim, validated to have identical key paths toen.jsoncomposables/useLocale.ts—'ko'added toSUPPORTED_LOCALES;한국어toNATIVE_LOCALE_NAMEScomposables/useCjkFontBanner.ts—'ko'added toCJK_LOCALES; install commands unchanged (noto-cjkis the unified CJK font)pages/settings.vue— Korean option added to the language pickerplugins/i18n.client.ts— registers the ko message bundleCJK banner design carry-over
script_labelinko.jsonis한국어(renders correctly when font present, tofus when missing — the bilingual header still carries meaning via the English half)Translation quality caveat
Machine-translated baseline. Not authored by a native Korean speaker. Polite-formal register (`-합니다` / `-하세요`). Treat any awkwardness or unidiomatic phrasing as a PR opportunity, not a bug — `_translator_notes` is set on the file. Korean-fluent contributors invited to PR against `locales/ko.json` per `CONTRIBUTING-i18n.md`.
Test plan
🤖 Generated with Claude Code