fix: remove vendored WP-CLI bundle#1192
Conversation
|
MERGE_SUMMARY Removed Verification:
|
📝 WalkthroughWalkthroughRemoves ChangesDev Dependencies Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
composer.json (1)
1-210: ⚖️ Poor tradeoffConsider aligning indentation with coding guidelines.
The entire file uses 4-space indentation, but the coding guidelines specify 2-space indentation for JSON files. While this is a pre-existing issue not introduced by this PR, consider reformatting the file to comply with the guideline in a future change.
As per coding guidelines: "Indent JSON and YAML files with 2 spaces (not tabs). See
.editorconfigfor configuration."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@composer.json` around lines 1 - 210, composer.json currently uses 4-space indentation; reformat the file to use 2-space indentation everywhere to match the project's coding guidelines (affecting top-level keys like "name", "autoload", "require", "scripts", etc.). Use a JSON formatter or your editor (or run a command-line tool like prettier/js-beautify) to convert all indentation to 2 spaces, validate the JSON after formatting, and commit the whitespace-only change with a clear message (e.g., "style: reformat composer.json to 2-space indentation").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@composer.json`:
- Around line 1-210: composer.json currently uses 4-space indentation; reformat
the file to use 2-space indentation everywhere to match the project's coding
guidelines (affecting top-level keys like "name", "autoload", "require",
"scripts", etc.). Use a JSON formatter or your editor (or run a command-line
tool like prettier/js-beautify) to convert all indentation to 2 spaces, validate
the JSON after formatting, and commit the whitespace-only change with a clear
message (e.g., "style: reformat composer.json to 2-space indentation").
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3ef4f938-00b0-4c94-a5c2-8a24376cef85
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
composer.json
Admin Merge Fallback (t2247)Branch protection blocked the plain Merge method: Original branch-protection errorRemediation: If this bypass was unintended, revert with aidevops.sh v3.15.38 plugin for OpenCode v1.14.48 with unknown spent 13m and 35,538 tokens on this with the user in an interactive session. |
|
Performance Test Results Performance test results for 27c510d are in 🛎️! Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown. URL:
|
Summary
wp-cli/wp-cli-bundledependency so the plugin no longer vendors WP-CLI command classes.composer.lockto dropwp-cli/search-replace-commandand the unused WP-CLI bundle dependency tree.Testing
composer installcomposer validate(passes with existing schema warnings)wp-cli/search-replace-commandandwp-cli/wp-cli-bundlewp --skip-plugins=ultimate-multisite --require="$PWD/ultimate-multisite.php" search-replace 'test-old-string-xyz' 'test-new-string-xyz' --dry-run --report-changed-only(exit 0)Resolves #1184
MERGE_SUMMARY: Removed the dev-only WP-CLI bundle from Composer dependencies and regenerated the lockfile so Ultimate Multisite no longer autoloads an incompatible vendored search-replace command during WP-CLI phar usage.
Summary by CodeRabbit