fix(accessapplication): adopt existing apps by domain instead of name

internal/clients/cf/access.go

@@ -1917,6 +1917,30 @@ func (c *API) ListAccessApplicationsByName(ctx context.Context, name string) (*A
 	return nil, fmt.Errorf("access application not found: %s", name)
 }
 
+// ListAccessApplicationsByDomain finds an Access Application by domain.
+func (c *API) ListAccessApplicationsByDomain(ctx context.Context, domain string) (*AccessApplicationResult, error) {
+	if _, err := c.GetAccountId(ctx); err != nil {
+		c.Log.Error(err, "error getting account ID")
+		return nil, err
+	}
+
+	rc := cloudflare.AccountIdentifier(c.ValidAccountId)
+
+	apps, _, err := c.CloudflareClient.ListAccessApplications(ctx, rc, cloudflare.ListAccessApplicationsParams{})
+	if err != nil {
+		c.Log.Error(err, "error listing access applications")
+		return nil, err
+	}
+
+	for _, app := range apps {
+		if app.Domain == domain {
+			return convertAccessApplicationToResult(app, c.ValidAccountId), nil
+		}
+	}
+
+	return nil, fmt.Errorf("access application not found: %s", domain)
+}
+
 // ============================================================================
 // Conversion helper functions for AccessApplication
 // ============================================================================

internal/clients/cf/interface.go

@@ -60,6 +60,7 @@ type CloudflareClient interface {
 	UpdateAccessApplication(ctx context.Context, applicationID string, params AccessApplicationParams) (*AccessApplicationResult, error)
 	DeleteAccessApplication(ctx context.Context, applicationID string) error
 	ListAccessApplicationsByName(ctx context.Context, name string) (*AccessApplicationResult, error)
+	ListAccessApplicationsByDomain(ctx context.Context, domain string) (*AccessApplicationResult, error)
 
 	// Access Policy operations
 	CreateAccessPolicy(ctx context.Context, params AccessPolicyParams) (*AccessPolicyResult, error)

internal/controller/accessapplication/controller.go

@@ -200,8 +200,8 @@ func (r *Reconciler) reconcileApplication(
 				"applicationID", existing.ID)
 		}
 	} else {
-		// Try to find existing by name first
-		existing, err := apiResult.API.ListAccessApplicationsByName(ctx, appName)
+		// Try to find existing by domain first
+		existing, err := apiResult.API.ListAccessApplicationsByDomain(ctx, params.Domain)
 		if err == nil && existing != nil {
 			// Found existing, adopt it
 			logger.Info("Found existing AccessApplication in Cloudflare, adopting",