fix(accessapplication): adopt existing apps by domain instead of name#44
Open
mxhob1 wants to merge 1 commit into
Open
fix(accessapplication): adopt existing apps by domain instead of name#44mxhob1 wants to merge 1 commit into
mxhob1 wants to merge 1 commit into
Conversation
When Status.ApplicationID is empty the reconciler adopts an existing Cloudflare app rather than creating one; it matched on the display name, which is not unique, so two AccessApplications sharing a name adopt the same app and overwrite each other's domain and policies. Match on the primary domain instead, which Cloudflare enforces as unique per account, and create a new app when nothing matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adoption — the path taken when
Status.ApplicationIDis empty — matched existingCloudflare apps by display name. Display names aren't unique, so two CRs sharing a
name adopt the same app and overwrite each other's domain and policies. Match on the
primary domain instead (unique per account), and create when there's no match.
Type of Change
Related Issues
Checklist
make test)make lint)make manifests generate)Testing
make testandmake lintpass;make manifests generateis a no-op.ListAccessApplicationsByDomainmirrors the existingListAccessApplicationsByName,which has no unit test in this package.
Additional Notes
Matches the primary domain only, not
SelfHostedDomains.