Mra/feat launcher#3
Conversation
Mael-RABOT
commented
May 27, 2026
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
win supported though git bash & WSL as fallback Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
58cdce7 to
057c158
Compare
Signed-off-by: Mael-RABOT <mael.rabot@epitech.eu>
There was a problem hiding this comment.
1:Ticking Developer mode or not does not change the launch, we have the same launch menu
Developer mode should be unticked by default when env is not set or not DEV=true, and be ticked by default when env is set to DEV=true, developer mode should also be the last element of the list, and separated by a blank line for install/build/launch.
This way the "default" user flow will be straightforward
2: After a run from TUI of target "Install", we got as output:
Install complete. Run ./launch_lucy.sh to start the stack.
--- Command finished with exit code 0 ---
Press Enter to exit.
Instead of prompting for re-run and exit, can we just prompt:
Install complete, press Enter to continue.
Also renaming "Install" to "Install/Update" could make sense as it is also the way to update the project
3: A launch with all options activated (except real hardware), when Ctrl+C in terminal is not stopping anything, it should stop everything and put us back to the TUI menu. But everything got stopped when exiting from the TUI
4: Using the console option, exiting with Ctrl+C or exit is not possible, Tmux Ctrl+B -> D is exiting the full lucy TUI
5: Launching the stack with Gazebo, then relaunching with Rviz (and unticking gazebo) is not stopping Gazebo run, but "hot-updating launch" activating/deactivating Rviz is working really good for example
|
@charlesmadjeri requested changes
edit: Gazebo can't be closed by commands with the current architecture, will be left as such |
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
|
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>