Skip to content

Detached-review cancel may not recover the broker (M3 edge) #4

Description

@Robbyfuu

Context

Documented limitation (see comments at the broker/recover ownership check in app-server-broker.mjs and handleCancel in codex-companion.mjs): for a DETACHED review, the job stores reviewThreadId while the broker may have keyed activeThreadIds on the source thread during the review/start round-trip window — so an ownership-scoped broker/recover can no-op (owned:false). The native inline /codex-plus:review path is unaffected.

Proposal

Persist/forward sourceThreadId end-to-end (job schema + progress normalization + cancel) OR seed the broker's activeThreadIds with the union of source + review thread ids from the start of the round-trip.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions