[Audit][High] Off-by-one type mismatch in OverworldV2Generator tree/vegetation placement bounds check

[MichaelFisher1997]

🔍 Module Scanned

modules/worldgen-overworld-v2/src/ (automated audit scan)

📝 Summary

In OverworldV2Generator, the tree placement and vegetation placement bounds checks compare terrain_height (i32) directly against CHUNK_SIZE_Y - 8 (u32 constant 248), causing a Zig signed-to-unsigned comparison that produces incorrect results when terrain_height > 248. This causes trees and vegetation to be incorrectly skipped at high altitudes (mountain peaks, jagged peaks).

📍 Location

• File: modules/worldgen-overworld-v2/src/root.zig:231
• Function/Scope: placeTrees() and placeVegetation()

🔴 Severity: High

• High: Incorrect rendering (missing trees/vegetation at high altitudes), broken features in mountainous terrain

💥 Impact

When terrain_height >= 248 (which easily occurs at mountainous peaks with sea_level=64):

• The comparison terrain_height >= CHUNK_SIZE_Y - 8 evaluates as terrain_height >= 248
• For terrain_height = 300, Zig performs 300 >= 248 = true, incorrectly skipping tree placement
• This affects trees (line 231) and vegetation (line 280), which both use the same boundary check pattern
• In mountainous worlds with peak heights of 140+ sea_level (204+ blocks), all trees are incorrectly suppressed

🔎 Evidence

Line 231 in placeTrees():

if (surface_y <= self.params.sea_level or surface_y >= CHUNK_SIZE_Y - 8) continue;

Line 280 in placeVegetation():

if (surface_y <= 0 or surface_y >= CHUNK_SIZE_Y - 2) continue;

The issue is the type mismatch in the comparison:

• surface_y is i32 (from chunk.getSurfaceHeight() which returns i16 promoted to i32)
• CHUNK_SIZE_Y is u32 = 256 (from world_core.CHUNK_SIZE_Y)
• CHUNK_SIZE_Y - 8 evaluates to u2 248 (truncated from u32)
• Zig performs signed-to-unsigned comparison, causing terrain heights > 248 to wrap

🛠️ Proposed Fix

Change the boundary checks to use explicit integer type casting:

// Line 231 - change from:
if (surface_y <= self.params.sea_level or surface_y >= CHUNK_SIZE_Y - 8) continue;
// To:
if (surface_y <= self.params.sea_level or surface_y >= @as(i32, CHUNK_SIZE_Y) - 8) continue;

// Line 280 - change from:
if (surface_y <= 0 or surface_y >= CHUNK_SIZE_Y - 2) continue;
// To:
if (surface_y <= 0 or surface_y >= @as(i32, CHUNK_SIZE_Y) - 2) continue;

Or equivalently, cast the upper bound to i32:

if (surface_y <= self.params.sea_level or surface_y >= @as(i32, CHUNK_SIZE_Y - 8)) continue;

✅ Acceptance Criteria

• Trees spawn correctly at terrain heights >= 248
• Vegetation spawns correctly at terrain heights >= 254
• Unit test verifies tree placement at mountain peaks (height ~140 with sea_level=64)
• Build succeeds with nix develop --command zig build

📚 References

• Zig integer comparison semantics: https://ziglang.org/documentation/master/#ComparisonOperators
• CHUNK_SIZE_Y defined in modules/world-core/src/chunk_constants.zig as 256
• Related: Issue [Audit][High] Off-by-one in buildSubchunk Y loop causes extra slice at subchunk boundary #705 (off-by-one error, different file)

[github-actions]

Comment:

Validated. The bug is real and correctly identified.

Root cause confirmed:

• surface_y at lines 231 and 280 is i16 from getSurfaceHeight(), promoted to i32 when used
• CHUNK_SIZE_Y is u32 = 256
• CHUNK_SIZE_Y - 8 evaluates to u32 (248)
• Zig's comparison semantics: when comparing i32 against u32, the i32 is converted to u32 (wrap on overflow). For terrain heights > 248, this causes surface_y >= 248 to wrap to false after the high bits are truncated, incorrectly skipping tree/vegetation placement

Scope: Only modules/worldgen-overworld-v2/src/root.zig — 3 locations:

• Line 231: placeTrees()
• Line 280: placeVegetation()
• Line 716: getLODTreePlacementSample() (same pattern, same issue)

Fix: The proposed cast to i32 is correct:

if (surface_y >= @as(i32, CHUNK_SIZE_Y) - 8) continue;

No duplicate issues found. Related issue #705 is in a different file (biome_decorator.zig) per the search.

Action needed: Implement the proposed fix. No tests currently cover high-altitude placement — adding a unit test per the acceptance criteria would validate the fix.

opencode session  |  github run

[MichaelFisher1997]

/oc confirm this issue still exists and implement a fix. OPEN A PULL REQUEST targeting dev — do NOT push directly to dev.

[MichaelFisher1997]

Created PR #828

opencode session  |  github run