Skip to content

Use __ldg on Scalar Read-only Data Stores#1795

Closed
fthaler wants to merge 2 commits into
GridTools:masterfrom
fthaler:data-store-ldg
Closed

Use __ldg on Scalar Read-only Data Stores#1795
fthaler wants to merge 2 commits into
GridTools:masterfrom
fthaler:data-store-ldg

Conversation

@fthaler

@fthaler fthaler commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

Uses the __ldg instruction on loads from read-only data stores with supported scalar data types. This might improve performance due to more optimal caching and helps NVCC to elide redundant load instructions.

@fthaler

fthaler commented Jul 24, 2024

Copy link
Copy Markdown
Contributor Author

launch perftest

@gridtoolsjenkins

Copy link
Copy Markdown
Collaborator

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

@fthaler

fthaler commented Jul 24, 2024

Copy link
Copy Markdown
Contributor Author

launch jenkins

@fthaler

fthaler commented Jul 24, 2024

Copy link
Copy Markdown
Contributor Author

launch perftest

@fthaler

fthaler commented Jul 24, 2024

Copy link
Copy Markdown
Contributor Author

launch jenkins

#include "../meta.hpp"
#include "data_store.hpp"

#if defined(__CUDA_ARCH__) && __CUDA_ARCH__ >= 350

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see both comments in the other __ldg pr

}
};
template <class T>
struct const_ptr_wrapper {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that better live somewhere in the sid module and possibly become the default also for simple_ptr_holder?

@fthaler

fthaler commented Aug 14, 2024

Copy link
Copy Markdown
Contributor Author

Closed in favor of #1802

@fthaler fthaler closed this Aug 14, 2024
fthaler added a commit that referenced this pull request Sep 24, 2024
Additionally fixes missing `host_view` etc. in const data stores. Gives
speedups when combined with #1795.
havogt pushed a commit that referenced this pull request Sep 30, 2024
Additionally fixes missing `host_view` etc. in const data stores. Gives
speedups when combined with #1795.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants