Skip to content

debugger: fix symdb test and enable for .net #7010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreimatei wants to merge 2 commits into
base: main
Choose a base branch
from
Open

debugger: fix symdb test and enable for .net #7010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea60468
debugger: match Content-Disposition name= with or without quotes
andreimatei May 22, 2026
3fdaa9a
debugger: unskip symdb test for dotnet
andreimatei May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions manifests/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,7 @@ manifest:
tests/debugger/test_debugger_probe_status.py::Test_Debugger_Line_Probe_Statuses::test_probe_status_log_line_with_windows_path: bug (DEBUG-5108)
tests/debugger/test_debugger_probe_status.py::Test_Debugger_Method_Probe_Statuses: v2.53.0
tests/debugger/test_debugger_symdb.py::Test_Debugger_SymDb: v2.53.0
# TODO(andrei): un-skip when v3.44.0 is released
tests/debugger/test_debugger_symdb.py::Test_Debugger_SymDb::test_event_metadata: missing_feature (extended event schema not yet shipped)
tests/debugger/test_debugger_symdb.py::Test_Debugger_SymDb::test_event_metadata: v3.44.0
tests/debugger/test_debugger_symdb.py::Test_Debugger_SymDb::test_symdb_upload: # Modified by easy win activation script
- declaration: bug (DEBUG-3298)
component_version: <3.36.0
Expand Down
7 changes: 5 additions & 2 deletions tests/debugger/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,8 @@ def _collect_symdb_upload_events(self):
gzipped symbols attachment (collected by _collect_symbols) and a
small JSON blob describing the upload (the "event" part). This
populates self.symdb_upload_events with the parsed event JSON for
every captured upload, matched by Content-Disposition name="event".
every captured upload, matched by the Content-Disposition name
parameter equaling "event".
"""
events: list[dict[str, Any]] = []
raw_data = list(interfaces.library.get_data(_SYMBOLS_PATH))
Expand All @@ -942,7 +943,9 @@ def _collect_symdb_upload_events(self):
if not isinstance(part, dict):
continue
disposition = part.get("headers", {}).get("content-disposition", "")
if 'name="event"' not in disposition:
# Disposition arrives quoted from some tracers (Python) and
# unquoted from others (.NET); normalize before checking.
if "name=event" not in disposition.replace('"', ""):
continue
content = part.get("content")
if isinstance(content, dict):
Expand Down
Loading