-
Notifications
You must be signed in to change notification settings - Fork 15
feat(nodejs): add base images and build infrastructure for Node.js weblogs #6903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rochdev
wants to merge
46
commits into
main
Choose a base branch
from
rochdev/nodejs-base-images
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
e0d26c3
feat(nodejs): add base images for Node.js weblogs
rochdev f8a7362
ci(nodejs): publish base images to GHCR automatically
rochdev 756bb2c
ci(nodejs): version base images by PR number
rochdev ed1386a
fix(ci): add packages:write permission to build_end_to_end job
rochdev a7be447
fix(ci): move nodejs base image push to dedicated ci.yml job
rochdev 22385e7
fix(nodejs): update parametric Dockerfile to use GHCR base image
rochdev 060da04
docs: update base image guide for Node.js GHCR workflow
rochdev f168564
fix(nodejs): add OCI source label to link packages to repo in GHCR
rochdev 40615a6
refactor(nodejs): scope base images to weblog/nodejs in GHCR
rochdev 1fde96d
refactor(ci): extract nodejs base image push to reusable workflow
rochdev 082de4b
refactor(nodejs): follow Python/PHP pattern for base image publishing
rochdev 116a336
fix(ci): add nodejs base image build step to parametric workflow
rochdev 64b3558
fix(nodejs): remove base images from integration framework weblogs
rochdev 9fc4669
perf(build): avoid docker save | gzip recompression when saving weblog
rochdev e33cca2
revert(build): revert --output type=docker, not supported by docker d…
rochdev 8ed1483
perf(build): use pigz instead of gzip when saving weblog image
rochdev ed85e01
perf(build): use zstd instead of pigz for weblog image compression
rochdev 50659d1
perf(nodejs): use bun for express4 dependency installation
rochdev 7931ff3
fix(lint): use bash array for bun args to satisfy shellcheck SC2086
rochdev ff9bd22
fix(nodejs): use alpine bun image to match musl libc on node:alpine
rochdev eec453c
fix(nodejs): remove hoisted linker from dd-trace install
rochdev feef5a3
fix(nodejs): add --trust to bun add for dd-trace lifecycle scripts
rochdev 0b51fa7
feat(nodejs): switch all weblogs to bun, use GHCR for weblog images
rochdev 7544e2d
revert(ci): revert GHCR weblog image sharing, restore artifact approach
rochdev af8c1fc
perf(ci): rebuild nodejs weblogs in run job, skip build+artifact step
rochdev d25adfc
fix(ci): use shared binaries artifact for nodejs build_in_run weblogs
rochdev a5bc840
perf(ci): save/load base image artifact instead of full weblog image
rochdev 4ae8461
fix(ci): handle unset TEST_LIBRARY/WEBLOG_VARIANT in load_base_image
rochdev 314ab7e
perf(nodejs): increase bun network-concurrency to 16 for dd-trace ins…
rochdev 27d1212
fix(ci): skip image pre-pull when base image artifact exists
rochdev 170d610
fix(ci): skip weblog build for nodejs when saving artifact
rochdev 53f8f10
fix(ci): pass TEST_LIBRARY from libraries array in run.sh for parametric
rochdev 8ad0968
fix(ci): revert parametric Dockerfile to node:18.10-slim
rochdev b2ac87f
revert: undo unauthorized commit bed1702f0
rochdev e1feb55
fix(ci): revert parametric to original npm-based Dockerfile
rochdev d47f330
fix(nodejs): switch parametric tests to bun, add bun binary
rochdev 77135c3
feat(ci): add _build_nodejs_base_images option to skip build jobs
rochdev 6b98b42
fix(lint): make build_weblog_images keyword-only to satisfy ruff FBT0…
rochdev 1bea95d
fix(ci): default build_weblog_images to true, only false for nodejs w…
rochdev eac24bc
fix(ci): default build_weblog_images to True in workflow_data.py
rochdev 329ce66
fix(ci): restore correct condition for Build nodejs weblog base image…
rochdev cdb6ccf
fix(ci): revert accidental _system_tests_dev_mode default change, fix…
rochdev 33bbf85
refactor(ci): unify weblog artifact naming for nodejs base images
rochdev 6e9ab75
fix: remove Node.js mention from generic --build-weblog-images help text
rochdev 887241e
fix(ci): restore missing fi closing docker inspect block in build.sh
rochdev 8095913
style: apply ruff formatting to compute-workflow-parameters.py
rochdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #!/usr/bin/env bash | ||
| set -e | ||
|
|
||
| if [ "$1" = "--push" ]; then | ||
| exec docker buildx bake --progress=plain -f "utils/build/docker/nodejs/docker-bake.hcl" "$@" | ||
| else | ||
| exec docker buildx bake --progress=plain --load -f "utils/build/docker/nodejs/docker-bake.hcl" "$@" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.