Automatic email address links render incorrectly

[meli-lewis]

HTML not rendering as hyperlink: http://openscienceframework.org/project/aQkUn/wiki/home

HTML rendering as hyperlinks: http://openscienceframework.org/project/EZcUj/node/KqgT5/wiki/home

[lyndsysimon]

HTML not rendering as hyperlink: http://openscienceframework.org/project/aQkUn/wiki/home

HTML rendering as hyperlinks: http://openscienceframework.org/project/EZcUj/node/KqgT5/wiki/home

Got it - the issue isn't that HTML renders differently, but that email addresses entered as text come out the other side as entity-encoded HTML. For instance, the following work fine:

<a href="mailto:user@domain.tld">user@domain.tld</a>
<a href="mailto:user.name@domain.tld">user.name@domain.tld</a>

user@domain.tld results in <a href='user@domain.tld'>user@domain.tld</a>.

I'm editing the title of this issue from "html rendering differently depending on page" to reflect this.

[lyndsysimon]

This was a problem with scrubber - per the open pull request on their Github repo, scrubber's autolink functionality hasn't worked for at least a year. I turned it off, and we seem to be good to go for now.

I recommend moving to an actively maintained HTML whitelist utility, or rolling our own. A cursory search turned up bleach, which is actively developed and appears to be complete. In addition, there is support for Python 3.x in the works, and the library handles unicode properly now.

I'll touch base with the other developers - if we decide to move to bleach, we should be able to quickly add the autolinking functionality that scrubber was improperly implementing.

[lyndsysimon]

Fixed in 5d264a9